Skip to content

[Release blocker] local tile switcher fix#4447

Merged
dmceachernmsft merged 3 commits intomainfrom
dmceachernmsft/local-tile-switcher-fix
Apr 10, 2024
Merged

[Release blocker] local tile switcher fix#4447
dmceachernmsft merged 3 commits intomainfrom
dmceachernmsft/local-tile-switcher-fix

Conversation

@dmceachernmsft
Copy link
Copy Markdown
Member

What

Fixes issue where local camera switcher is blocked by the reactions overlay

Why

allows for local user to switch their camera

https://skype.visualstudio.com/SPOOL/_workitems/edit/3672913

How Tested

Validated locally will cp into release for further bug bashing

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 10, 2024

CallWithChat bundle size is decreased✅.

  • Current size: 6187606
  • Base size: 6187746
  • Diff size: -140

@github-actions
Copy link
Copy Markdown
Contributor

Chat bundle size is not changed.

  • Current size: 2108760
  • Base size: 2108760
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 10, 2024

Calling bundle size is decreased✅.

  • Current size: 4807877
  • Base size: 4808009
  • Diff size: -132

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 25184 / 39115
64.38%
25184 / 39115
64.38%
675 / 1215
55.55%
1954 / 3111
62.8%
Current 25164 / 39095
64.36%
25164 / 39095
64.36%
675 / 1215
55.55%
1954 / 3111
62.8%
Diff -20 / -20
-0.02%
-20 / -20
-0.02%
0 / 0
0%
0 / 0
0%

@github-actions
Copy link
Copy Markdown
Contributor

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 49609 / 79133
62.69%
49609 / 79133
62.69%
1019 / 2267
44.94%
2854 / 4692
60.82%
Current 49633 / 79109
62.74%
49633 / 79109
62.74%
1019 / 2267
44.94%
2875 / 4710
61.04%
Diff 24 / -24
0.05%
24 / -24
0.05%
0 / 0
0%
21 / 18
0.22%

@dmceachernmsft dmceachernmsft enabled auto-merge (squash) April 10, 2024 19:03
@dmceachernmsft dmceachernmsft merged commit 2955d69 into main Apr 10, 2024
@dmceachernmsft dmceachernmsft deleted the dmceachernmsft/local-tile-switcher-fix branch April 10, 2024 19:07
dmceachernmsft added a commit that referenced this pull request Apr 10, 2024
* fix local tile switcher action

* Change files
dmceachernmsft added a commit that referenced this pull request Apr 10, 2024
* fix local tile switcher action

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants