Conversation
Contributor
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
Calling bundle size is not changed.
|
Contributor
Contributor
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
jpeng-ms
requested review from
AmyL219,
JamesBurnside,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
jimchou-dev,
mgamis-msft and
prabhjot-msft
Contributor
Contributor
emlynmac
reviewed
Apr 17, 2024
| registerCompletedUploads: (metadata: AttachmentMetadata[]) => AttachmentUploadTask[]; | ||
| // (undocumented) | ||
| updateUploadMetadata: (id: string, metadata: AttachmentMetadata) => void; | ||
| updateUploadMetadata: (id: string, metadata: AttachmentMetadataWithProgress | AttachmentMetadata) => void; |
Member
There was a problem hiding this comment.
This should only take the AttachmentMetadataWithProgress shouldn't it?
Contributor
Contributor
Contributor
jimchou-dev
approved these changes
Apr 18, 2024
emlynmac
reviewed
Apr 18, 2024
| /** | ||
| * Optional array of active attachment uploads where each object has attributes | ||
| * of a attachment upload like name, progress, errorMessage etc. | ||
| * Optional array of type {@linkAttachmentMetadataWithProgress} |
Member
There was a problem hiding this comment.
Suggested change
| * Optional array of type {@linkAttachmentMetadataWithProgress} | |
| * Optional array of type {@link AttachmentMetadataWithProgress} |
emlynmac
reviewed
Apr 18, 2024
| /** | ||
| * Optional array of active attachment uploads where each object has attributes | ||
| * of a attachment upload like name, progress, errorMessage etc. | ||
| * Optional array of type {@linkAttachmentMetadataWithProgress} |
Member
There was a problem hiding this comment.
Suggested change
| * Optional array of type {@linkAttachmentMetadataWithProgress} | |
| * Optional array of type {@link AttachmentMetadataWithProgress} |
emlynmac
reviewed
Apr 18, 2024
|
|
||
| /** | ||
| * Metadata containing basic information about the uploaded attachment. | ||
| * Metadata containing basic information about attachment. |
Member
There was a problem hiding this comment.
Suggested change
| * Metadata containing basic information about attachment. | |
| * Metadata containing basic information about the attachment. |
emlynmac
reviewed
Apr 18, 2024
emlynmac
reviewed
Apr 18, 2024
emlynmac
approved these changes
Apr 18, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR contains the following changes:
AttachmentMetadataWithProgresshandleAttachmentSelectionandhandleAttachmentRemovalAttachmentUploadAdapterby making it internalWhy
Address review feedback
How Tested
CI
Process & policy checklist
Is this a breaking change?