Skip to content

[bugfix] Add adapter options to CallComposite.js files#4486

Merged
dmceachernmsft merged 8 commits intomainfrom
dmceachernmsft/adapter-options-js
Apr 19, 2024
Merged

[bugfix] Add adapter options to CallComposite.js files#4486
dmceachernmsft merged 8 commits intomainfrom
dmceachernmsft/adapter-options-js

Conversation

@dmceachernmsft
Copy link
Copy Markdown
Member

What

Add adapter options to the CallComposite JS files

Why

Allows Contoso to use the following with the JS bundle:

  • reactions
  • calling sounds
  • Teams bot rename

https://skype.visualstudio.com/SPOOL/_workitems/edit/3653697

How Tested

Validated locally, will make a new release of the JS bundles following next beta release

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 18, 2024

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 25165 / 39144
64.28%
25165 / 39144
64.28%
681 / 1222
55.72%
2011 / 3164
63.55%
Current 25164 / 39144
64.28%
25164 / 39144
64.28%
681 / 1222
55.72%
1984 / 3150
62.98%
Diff -1 / 0
0%
-1 / 0
0%
0 / 0
0%
-27 / -14
-0.57%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 18, 2024

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 49630 / 79166
62.69%
49630 / 79166
62.69%
1025 / 2278
44.99%
2916 / 4756
61.31%
Current 49633 / 79165
62.69%
49633 / 79165
62.69%
1025 / 2278
44.99%
2899 / 4745
61.09%
Diff 3 / -1
0%
3 / -1
0%
0 / 0
0%
-17 / -11
-0.22%

Comment thread samples/StaticHtmlComposites/src/outboundCallComposite.js Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 18, 2024

Chat bundle size is increased❗.

  • Current size: 2138316
  • Base size: 2138315
  • Diff size: 1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 18, 2024

CallWithChat bundle size is increased❗.

  • Current size: 6188533
  • Base size: 6188532
  • Diff size: 1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 18, 2024

Calling bundle size is increased❗.

  • Current size: 4811525
  • Base size: 4811372
  • Diff size: 153

@dmceachernmsft dmceachernmsft enabled auto-merge (squash) April 18, 2024 23:45
@github-actions
Copy link
Copy Markdown
Contributor

@dmceachernmsft dmceachernmsft disabled auto-merge April 18, 2024 23:57
@github-actions
Copy link
Copy Markdown
Contributor

@dmceachernmsft dmceachernmsft enabled auto-merge (squash) April 19, 2024 00:11
@dmceachernmsft dmceachernmsft merged commit a1468d3 into main Apr 19, 2024
@dmceachernmsft dmceachernmsft deleted the dmceachernmsft/adapter-options-js branch April 19, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants