[Chat] Fix Issue where screen reader announces " "#4500
Merged
Conversation
jpeng-ms
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
Contributor
Contributor
Calling bundle size is not changed.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
JoshuaLai
reviewed
Apr 22, 2024
| let attachmentList = ''; | ||
| /* @conditional-compile-remove(attachment-download) */ | ||
| attachmentList = attachmentCardGroupDescription(props); | ||
| /* @conditional-compile-remove(attachment-download) */ |
Member
There was a problem hiding this comment.
Small behavioural change with the cc moving outside of the if condition but this should be ok since the previous logic should have been around all attachments list anyways. But if anyone sees a reason why this might break stable builds please bring it up
Member
Author
There was a problem hiding this comment.
this if condition was added by me few weeks ago specifically for file sharing: https://github.com/Azure/communication-ui-library/pull/4438/files
added comments to explain this a bit
JoshuaLai
approved these changes
Apr 22, 2024
Contributor
Contributor
jimchou-dev
approved these changes
Apr 22, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This bug is only happening in windows narrator and not in mac voiceover. Currently, it will announces spaces out such as "John says image   image  " instead of "john says image image"
Why
addressing issues from A11y team
How Tested
test this in windows narrator
Process & policy checklist
Is this a breaking change?