Skip to content

[bugfix][a11y] participantitem icon color contrast requirement#4640

Merged
edwardlee-msft merged 9 commits intomainfrom
elee/bugfix-a11y-mute-button-color-contrast
May 22, 2024
Merged

[bugfix][a11y] participantitem icon color contrast requirement#4640
edwardlee-msft merged 9 commits intomainfrom
elee/bugfix-a11y-mute-button-color-contrast

Conversation

@edwardlee-msft
Copy link
Copy Markdown
Contributor

What

Change icon color in participant
image

Why

Accessibility contrast requirements
image

How Tested

MacOS Chrome local calling sample

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2024

CallWithChat bundle size is increased❗.

  • Current size: 6170355
  • Base size: 6170353
  • Diff size: 2

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2024

Calling bundle size is increased❗.

  • Current size: 4845729
  • Base size: 4845727
  • Diff size: 2

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2024

Chat bundle size is increased❗.

  • Current size: 2056537
  • Base size: 2056535
  • Diff size: 2

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@edwardlee-msft edwardlee-msft added the update_snapshots Set this label to request automated update of UI snapshots label May 21, 2024
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label May 21, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2024

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 25770 / 39998
64.42%
25770 / 39998
64.42%
710 / 1255
56.57%
2067 / 3251
63.58%
Current 25826 / 39998
64.56%
25826 / 39998
64.56%
710 / 1255
56.57%
2080 / 3263
63.74%
Diff 56 / 0
0.14%
56 / 0
0.14%
0 / 0
0%
13 / 12
0.16%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2024

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 50255 / 80230
62.63%
50255 / 80230
62.63%
1028 / 2278
45.12%
2945 / 4823
61.06%
Current 50226 / 80230
62.6%
50226 / 80230
62.6%
1028 / 2278
45.12%
2910 / 4801
60.61%
Diff -29 / 0
-0.03%
-29 / 0
-0.03%
0 / 0
0%
-35 / -22
-0.45%

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@edwardlee-msft edwardlee-msft enabled auto-merge (squash) May 22, 2024 17:16
@edwardlee-msft edwardlee-msft merged commit a0bb4e2 into main May 22, 2024
@edwardlee-msft edwardlee-msft deleted the elee/bugfix-a11y-mute-button-color-contrast branch May 22, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants