[Bugfix] PiPiP Stop scaling mode popup#4652
Merged
dmceachernmsft merged 5 commits intomainfrom May 24, 2024
Merged
Conversation
dmceachernmsft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
JamesBurnside
approved these changes
May 23, 2024
Contributor
Contributor
Chat bundle size is not changed.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
mgamis-msft
reviewed
May 23, 2024
| convertContextualMenuItemsToDrawerMenuItemProps(contextualMenuProps, () => | ||
| setDrawerMenuItemProps([]) | ||
| ) | ||
| ) |
Contributor
There was a problem hiding this comment.
nit: maybe you can use ?? here like:
props.onLongTouch ?? () =>
setDrawerMenuItemProps(
convertContextualMenuItemsToDrawerMenuItemProps(contextualMenuProps, () =>
setDrawerMenuItemProps([])
)
)
mgamis-msft
approved these changes
May 23, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the scaling mode options from the PiPiP per design suggestion
Why
Stops the scaling mode options from popping up when user is dragging the modal after a long press
https://skype.visualstudio.com/SPOOL/_workitems/edit/3688043
How Tested
Validated locally
Record_2024-05-23-11-58-19.mp4