[A11y][chat]Remove theme8 color palette for <Link>#4691
Merged
Conversation
AmyL219
requested review from
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
Calling bundle size is not changed.
|
Contributor
CallWithChat bundle size is decreased✅.
|
Contributor
Chat bundle size is decreased✅.
|
Contributor
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
| errorText: themeV8.semanticColors.errorText, | ||
| colorNeutralStroke1Selected: themeV8.palette.neutralQuaternary, | ||
| colorNeutralForeground2: themeV8.palette.neutralSecondary, | ||
| colorBrandForegroundLink: themeV8.palette.themePrimary, |
Member
There was a problem hiding this comment.
Are we good with the default value instead then? Do we need to update colorBrandForegroundLinkHover too?
Contributor
Author
There was a problem hiding this comment.
The default color is set as colorBrandForegroundLink: palette.themeDarkAlt,, themeDarkAlt is what Alex P want. And for Hover one, AlexP doesn't mention a update on it
Member
There was a problem hiding this comment.
Could you check with Alex on the hover state(so we won't forget about it)? Otherwise, looks good to me!
Contributor
Author
There was a problem hiding this comment.
Yeah, I have confirmed with AlexP
vhuseinova-msft
approved these changes
Jun 5, 2024
palatter
approved these changes
Jun 5, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix A11y issue for the ticket
The v9 theme pattern has the correct schema based on Alex P's input. So remove the v8 color theme overwrite in the token.
Why
How Tested
Process & policy checklist
Is this a breaking change?