Use participant list name for captions so onFetchProfile works as expected #4703
Merged
carocao-msft merged 10 commits intomainfrom Jun 6, 2024
Merged
Use participant list name for captions so onFetchProfile works as expected #4703carocao-msft merged 10 commits intomainfrom
carocao-msft merged 10 commits intomainfrom
Conversation
carocao-msft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
edwardlee-msft
approved these changes
Jun 5, 2024
Contributor
Calling bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is not changed.
|
Contributor
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
PorterNan
approved these changes
Jun 5, 2024
Contributor
PorterNan
left a comment
PorterNan
left a comment
There was a problem hiding this comment.
Nice! Let's make sure from SDK team that there are no concerns that we are using participant displayName instead of caption displayName
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
carocao-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
communication-ui-bot
requested review from
AmyL219,
JoshuaLai,
Leah-Xia-Microsoft,
emlynmac,
jimchou-dev,
jpeng-ms,
palatter,
vhuseinova-msft and
waynemo
…unication-ui-library into carocao/Captions_name
…unication-ui-library into carocao/Captions_name
…unication-ui-library into carocao/Captions_name
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Use participant list name for captions so onFetchProfile works as expected
Why
How Tested
Tested with samples
Process & policy checklist
Is this a breaking change?