[Chat] Added Styling to Disabled Attachment Card Group#4711
Merged
Conversation
jpeng-ms
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
Chat bundle size is increased❗.
|
Contributor
Calling bundle size is not changed.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
| */ | ||
| export const useCustomStyles = makeStyles({ | ||
| root: { | ||
| backgroundColor: 'rgb(0,0,0,0)' |
Member
There was a problem hiding this comment.
Suggested change
| backgroundColor: 'rgb(0,0,0,0)' | |
| backgroundColor: 'transparent' |
In this case we will be consistent with other places where we use transparent background and it's a little bit more readable
Contributor
…ure/communication-ui-library into john/attachment-disable-state
Contributor
Contributor
Contributor
vhuseinova-msft
approved these changes
Jun 13, 2024
jimchou-dev
reviewed
Jun 13, 2024
Contributor
Contributor
jimchou-dev
approved these changes
Jun 17, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR adds support yo disable attachment card group, when attachment card group is disabled, the user interaction is disabled and background color is set to semi-transparent to indicate the disabled state
Why
improvement
How Tested
Storybook link generated by CI
Process & policy checklist
Is this a breaking change?