[RTE] Fix for rich text editor toolbar buttons hover state on Android devices#4748
Merged
vhuseinova-msft merged 10 commits intomainfrom Jun 18, 2024
Merged
Conversation
…tton-hover-state-fix-android
vhuseinova-msft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
prabhjot-msft and
waynemo
Contributor
Contributor
Calling bundle size is not changed.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
emlynmac
approved these changes
Jun 18, 2024
Member
|
@vhuseinova-msft do the snapshots need updating? Are they now reflecting what they should? |
palatter
approved these changes
Jun 18, 2024
Member
Ya looks like the original snapshot was not the intended behaviour and they should be updated. |
Member
|
Tested on Android and behavior looks correct |
Member
Author
@palatter you're right! Updating them right now |
vhuseinova-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
Leah-Xia-Microsoft
approved these changes
Jun 18, 2024
Member
Leah-Xia-Microsoft
left a comment
Leah-Xia-Microsoft
left a comment
There was a problem hiding this comment.
Tested on Android and can confirm the fix.
Contributor
vhuseinova-msft
deleted the
vhuseinova/toolbar-button-hover-state-fix-android
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Previously, the rich text editor toolbar buttons (bold, italic...) were shown as selected even when the styles weren't applied. This PR is to fix this issue.
Steps to reproduce:
Why
How Tested
Process & policy checklist
Is this a breaking change?