[Beta blocking] Fix missing pinned icon when it is the only icon#4751
Merged
mgamis-msft merged 2 commits intomainfrom Jun 18, 2024
Merged
[Beta blocking] Fix missing pinned icon when it is the only icon#4751mgamis-msft merged 2 commits intomainfrom
mgamis-msft merged 2 commits intomainfrom
Conversation
mgamis-msft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
mgamis-msft
changed the title
alkwa-msft
approved these changes
Jun 18, 2024
Contributor
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
prabhjot-msft
approved these changes
Jun 18, 2024
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
mgamis-msft
added a commit
that referenced
this pull request
Jun 18, 2024
* Fix missing pinned icon when it is the only icon for a remote participant * Change files
3 tasks
emlynmac
pushed a commit
that referenced
this pull request
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix missing pinned icon when it is the only icon by updating logic for onRenderIcon prop in ParticipantList
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3765795
How Tested
Testing locally on CallWithChat app
Process & policy checklist
Is this a breaking change?