Skip to content

[RTE][A11Y] Resolve A11Y issue where show richTextEditor button didn't have aria-expanded attribute#4759

Merged
palatter merged 2 commits intomainfrom
palatter/rte-format-button-expand-collapse-a11y
Jun 19, 2024
Merged

[RTE][A11Y] Resolve A11Y issue where show richTextEditor button didn't have aria-expanded attribute#4759
palatter merged 2 commits intomainfrom
palatter/rte-format-button-expand-collapse-a11y

Conversation

@palatter
Copy link
Copy Markdown
Member

@palatter palatter commented Jun 19, 2024

What

Show richTextEditor should indicate to Voice Over whether its expanded or collapsed.

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@palatter palatter requested review from a team as code owners June 19, 2024 19:56
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 19, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-cxznscrhwf.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 19, 2024 •
edited
Loading

CallWithChat bundle size is increased❗.

  • Current size: 6392137
  • Base size: 6392086
  • Diff size: 51

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 19, 2024

Calling bundle size is not changed.

  • Current size: 5031607
  • Base size: 5031607
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 19, 2024 •
edited
Loading

Chat bundle size is increased❗.

  • Current size: 2099306
  • Base size: 2099255
  • Diff size: 51

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 19, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-gpfafokzaa.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 19, 2024

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 51100 / 82622
61.84%		 51100 / 82622
61.84%		 1037 / 2323
44.64%		 3017 / 4927
61.23%
Current 51103 / 82626
61.84%		 51103 / 82626
61.84%		 1037 / 2323
44.64%		 3019 / 4933
61.2%
Diff 3 / 4
0%		 3 / 4
0%		 0 / 0
0%		 2 / 6
-0.03%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 19, 2024

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26205 / 41097
63.76%		 26205 / 41097
63.76%		 715 / 1284
55.68%		 2075 / 3315
62.59%
Current 26173 / 41099
63.68%		 26173 / 41099
63.68%		 715 / 1284
55.68%		 2071 / 3302
62.71%
Diff -32 / 2
-0.08%		 -32 / 2
-0.08%		 0 / 0
0%		 -4 / -13
0.12%

@palatter palatter changed the title Resolve A11Y issue where show richTextEditor button didn't have aria-expanded attribute [RTE][A11Y] Resolve A11Y issue where show richTextEditor button didn't have aria-expanded attribute Jun 19, 2024
@palatter palatter merged commit ba63647 into main Jun 19, 2024
@palatter palatter deleted the palatter/rte-format-button-expand-collapse-a11y branch June 19, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpeng-ms jpeng-ms jpeng-ms approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

+1 more reviewer

@vhuseinova-msft vhuseinova-msft vhuseinova-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@palatter @vhuseinova-msft @jpeng-ms
⚡