[Chat] Updated sample to disable BYOS file sharing in Teams calls#4786
Merged
[Chat] Updated sample to disable BYOS file sharing in Teams calls#4786
Conversation
jpeng-ms
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Calling bundle size is not changed.
|
Contributor
Chat bundle size is not changed.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
vhuseinova-msft
approved these changes
Jun 26, 2024
Leah-Xia-Microsoft
approved these changes
Jun 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
BYOS file sharing is only supported in ACS group calls, so we need to hide the attachment upload icon for Teams calls.
ACS call:
Teams call:
Why
improvement
How Tested
callwithchat sample app
Process & policy checklist
Is this a breaking change?