Skip to content

[A11y][Chat] Update Failure icon color in dark mode#4811

Merged
AmyL219 merged 10 commits intomainfrom
amyl/a11y/failSendingIcon
Jul 5, 2024
Merged

[A11y][Chat] Update Failure icon color in dark mode#4811
AmyL219 merged 10 commits intomainfrom
amyl/a11y/failSendingIcon

Conversation

@AmyL219
Copy link
Copy Markdown
Contributor

@AmyL219 AmyL219 commented Jul 3, 2024

What

Screenshot 2024-07-03 at 12 06 55 PM
Screenshot 2024-07-03 at 12 08 28 PM

Why

https://skype.visualstudio.com/SPOOL/_workitems/edit/3747497

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 3, 2024

Chat bundle size is increased❗.

  • Current size: 2106809
  • Base size: 2106770
  • Diff size: 39

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 3, 2024

Calling bundle size is not changed.

  • Current size: 5036910
  • Base size: 5036910
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 3, 2024

CallWithChat bundle size is increased❗.

  • Current size: 6404883
  • Base size: 6404844
  • Diff size: 39

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 3, 2024

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 3, 2024

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26480 / 41452
63.88%
26480 / 41452
63.88%
719 / 1294
55.56%
2119 / 3344
63.36%
Current 26480 / 41452
63.88%
26480 / 41452
63.88%
719 / 1294
55.56%
2115 / 3343
63.26%
Diff 0 / 0
0%
0 / 0
0%
0 / 0
0%
-4 / -1
-0.1%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 3, 2024

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 51180 / 83005
61.65%
51180 / 83005
61.65%
1034 / 2330
44.37%
3013 / 4928
61.14%
Current 51186 / 83005
61.66%
51186 / 83005
61.66%
1034 / 2330
44.37%
3007 / 4923
61.08%
Diff 6 / 0
0.01%
6 / 0
0.01%
0 / 0
0%
-6 / -5
-0.06%

Comment thread packages/react-components/src/theming/themes.ts Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 3, 2024

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 3, 2024

@AmyL219 AmyL219 enabled auto-merge (squash) July 3, 2024 22:38
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 3, 2024

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 4, 2024

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 5, 2024

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 5, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 5, 2024

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 5, 2024

@AmyL219 AmyL219 merged commit f43a0f9 into main Jul 5, 2024
@AmyL219 AmyL219 deleted the amyl/a11y/failSendingIcon branch July 5, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants