Skip to content

[Chat] Fixed the issue where image placeholder doesn't work for Safari Browser #4846

Merged
jpeng-ms merged 20 commits intomainfrom
john/loading-img-fix
Jul 15, 2024
Merged

[Chat] Fixed the issue where image placeholder doesn't work for Safari Browser #4846
jpeng-ms merged 20 commits intomainfrom
john/loading-img-fix

Conversation

@jpeng-ms
Copy link
Copy Markdown
Member

@jpeng-ms jpeng-ms commented Jul 11, 2024

What

Fixed the issue where image loading placeholder doesn't work for safari

Screenshot 2024-07-10 at 12 04 00 AM Screenshot 2024-07-10 at 12 03 33 AM

Why

bug fix

How Tested

storybook samples

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 11, 2024

Calling bundle size is increased❗.

  • Current size: 5086669
  • Base size: 5086668
  • Diff size: 1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 11, 2024

Chat bundle size is increased❗.

  • Current size: 2108366
  • Base size: 2108216
  • Diff size: 150

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 11, 2024

CallWithChat bundle size is increased❗.

  • Current size: 6442272
  • Base size: 6442122
  • Diff size: 150

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 11, 2024

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26640 / 42066
63.32%
26640 / 42066
63.32%
719 / 1297
55.43%
2131 / 3364
63.34%
Current 26598 / 42080
63.2%
26598 / 42080
63.2%
720 / 1298
55.46%
2097 / 3340
62.78%
Diff -42 / 14
-0.12%
-42 / 14
-0.12%
1 / 1
0.03%
-34 / -24
-0.56%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 11, 2024

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 52445 / 84529
62.04%
52445 / 84529
62.04%
1065 / 2366
45.01%
2986 / 5042
59.22%
Current 52530 / 84544
62.13%
52530 / 84544
62.13%
1066 / 2367
45.03%
3156 / 5143
61.36%
Diff 85 / 15
0.09%
85 / 15
0.09%
1 / 1
0.02%
170 / 101
2.14%

@jpeng-ms jpeng-ms added the update_snapshots Set this label to request automated update of UI snapshots label Jul 11, 2024
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jul 11, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@jpeng-ms jpeng-ms added the update_snapshots Set this label to request automated update of UI snapshots label Jul 11, 2024
@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

Comment thread packages/react-components/src/components/styles/MessageThread.styles.ts Outdated
Copy link
Copy Markdown
Member

@vhuseinova-msft vhuseinova-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment but otherwise looks good!

@github-actions
Copy link
Copy Markdown
Contributor

@jpeng-ms jpeng-ms enabled auto-merge (squash) July 15, 2024 20:21
@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@jpeng-ms jpeng-ms merged commit f77faed into main Jul 15, 2024
@jpeng-ms jpeng-ms deleted the john/loading-img-fix branch July 15, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants