Update paddings and theme handling for rich text editor toolbar#4852
Update paddings and theme handling for rich text editor toolbar#4852vhuseinova-msft merged 18 commits intomainfrom
Conversation
vhuseinova-msft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft and
waynemo
vhuseinova-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
|
Storybook 6 URL https://60c7ae6891f0e90039d7cd54-gmjpavrikh.chromatic.com/ |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Chat bundle size is increased❗.
|
CallWithChat bundle size is increased❗.
|
Calling bundle size is not changed.
|
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
…editor-padding-fix
|
Storybook 6 URL https://60c7ae6891f0e90039d7cd54-bgeqjomaej.chromatic.com/ |
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-boivafahrk.chromatic.com/ |
|
Storybook 6 URL https://60c7ae6891f0e90039d7cd54-cuclsekdwq.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-dcpzaevrqz.chromatic.com/ |
|
Storybook 6 URL https://60c7ae6891f0e90039d7cd54-kgfpsblvvq.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-crdrsqqtjr.chromatic.com/ |
|
Storybook 6 URL https://60c7ae6891f0e90039d7cd54-zlknqfwfqq.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-iveywkjffp.chromatic.com/ |
|
Storybook 6 URL https://60c7ae6891f0e90039d7cd54-aomrjzhhab.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-rgdhfujwob.chromatic.com/ |
| // check that editor exists and theme was actually changed | ||
| if (editor.current && previousThemeDirection.current !== themeDirectionValue) { | ||
| const format = getFormatState(editor.current); | ||
| if (format.direction !== themeDirectionValue) { |
There was a problem hiding this comment.
Isn't checking format.direction already sufficient? Do we need to introduce previousThemeDirection?
There was a problem hiding this comment.
Unfortunately, it's not sufficient as format.direction is set only after set direction function is called and that's why we need to upderstand if this a real change of theme direction or it's just an initial theme value for this component
There was a problem hiding this comment.
One of the issues about calling setDirection when setting the initial value of theme is that setDirection uses focus call inside and it won't work very well with our autoFocus prop
There was a problem hiding this comment.
Unfortunately, it's not sufficient as format.direction is set only after set direction function is called and that's why we need to upderstand if this a real change of theme direction or it's just an initial theme value for this component
Should we add a comment here to document this information? I feel it's quite useful to remember this finding.
|
Storybook 6 URL https://60c7ae6891f0e90039d7cd54-gexgomawad.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-xsslpbdyzi.chromatic.com/ |
3 participants
What
Why
How Tested
storybook
Process & policy checklist
Is this a breaking change?