Skip to content

RoosterJS dependencies update#4874

Merged
vhuseinova-msft merged 11 commits intomainfrom
vhuseinova/rooster-dependencies-update
Jul 19, 2024
Merged

RoosterJS dependencies update#4874
vhuseinova-msft merged 11 commits intomainfrom
vhuseinova/rooster-dependencies-update

Conversation

@vhuseinova-msft
Copy link
Copy Markdown
Member

@vhuseinova-msft vhuseinova-msft commented Jul 16, 2024

What

  • update RoosterJS dependencies
  • exported DefaultSanitizers from roosterjs and removed local copy
  • added announcements when bulleted and numbered lists button are clicked
  • added announcements when new bulleted and numbered lists items are added

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 16, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-mvfsgmfzyd.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 16, 2024 •
edited
Loading

Chat bundle size is increased❗.

  • Current size: 2097241
  • Base size: 2094508
  • Diff size: 2733

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 16, 2024 •
edited
Loading

Calling bundle size is increased❗.

  • Current size: 5081326
  • Base size: 5080808
  • Diff size: 518

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 16, 2024 •
edited
Loading

CallWithChat bundle size is increased❗.

  • Current size: 6431615
  • Base size: 6428861
  • Diff size: 2754

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 16, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-yxlwyureeg.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 19, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-wsdnprnjtq.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 19, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-azihluqeam.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 19, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-aqutaixhyc.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 19, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-dzhgobzwcs.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 19, 2024 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26619 / 42116
63.2%		 26619 / 42116
63.2%		 722 / 1300
55.53%		 2104 / 3346
62.88%
Current 26615 / 42138
63.16%		 26615 / 42138
63.16%		 722 / 1299
55.58%		 2097 / 3340
62.78%
Diff -4 / 22
-0.04%		 -4 / 22
-0.04%		 0 / -1
0.05%		 -7 / -6
-0.1%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 19, 2024 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 52542 / 84663
62.06%		 52542 / 84663
62.06%		 1068 / 2370
45.06%		 3013 / 5062
59.52%
Current 52542 / 84688
62.04%		 52542 / 84688
62.04%		 1068 / 2369
45.08%		 2997 / 5055
59.28%
Diff 0 / 25
-0.02%		 0 / 25
-0.02%		 0 / -1
0.02%		 -16 / -7
-0.24%

@vhuseinova-msft vhuseinova-msft marked this pull request as ready for review July 19, 2024 17:13
@vhuseinova-msft vhuseinova-msft requested review from a team as code owners July 19, 2024 17:13
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 19, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-cfbaitwqdp.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 19, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-xknwntcrxw.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 19, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-wctiedrenx.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 19, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-akfgagtazp.chromatic.com/

palatter
palatter reviewed Jul 19, 2024
View reviewed changes
Comment thread packages/storybook8/stories/Composites/ChatComposite/Docs.mdx
vhuseinova-msft
vhuseinova-msft commented Jul 19, 2024
View reviewed changes
Comment thread packages/react-components/src/components/RichTextEditor/RichTextEditor.tsx
}, [theme]);

useEffect(() => {
editor.current?.setDarkModeState(isDarkThemedValue);
Copy link
Copy Markdown
Member Author

@vhuseinova-msft vhuseinova-msft Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this anymore as editor creation useEffect already depends on theme and will be updated when theme is changed

@vhuseinova-msft vhuseinova-msft merged commit 4b8a197 into main Jul 19, 2024
@vhuseinova-msft vhuseinova-msft deleted the vhuseinova/rooster-dependencies-update branch July 19, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@palatter palatter palatter approved these changes

@Leah-Xia-Microsoft Leah-Xia-Microsoft Leah-Xia-Microsoft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

No one assigned

Labels

breaking-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vhuseinova-msft @palatter @Leah-Xia-Microsoft
⚡