Skip to content

[RTE] Fix selected format styles in rich text toolbar when editing messages#4940

Merged
vhuseinova-msft merged 9 commits intomainfrom
vhuseinova/rte-toolbar-bug-fix
Jul 26, 2024
Merged

[RTE] Fix selected format styles in rich text toolbar when editing messages#4940
vhuseinova-msft merged 9 commits intomainfrom
vhuseinova/rte-toolbar-bug-fix

Conversation

@vhuseinova-msft
Copy link
Copy Markdown
Member

@vhuseinova-msft vhuseinova-msft commented Jul 24, 2024

What

  • Fix for an issue where toolbar didn't correctly show the selected style format during message editing
  • Fix Storybook

Steps to reproduce:

  • open MessageThread preview page in Storybook
  • edit a message so it will contain some text style formatting at the end (bold, italic, underlined)
  • save the change
  • start editing the same message
  • open toolbar
  • check that the correct syle is applied

Why

How Tested

Storybook

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@vhuseinova-msft vhuseinova-msft requested review from a team as code owners July 24, 2024 23:01
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 24, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-fjfplpasrs.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 24, 2024 •
edited
Loading

CallWithChat bundle size is increased❗.

  • Current size: 6324830
  • Base size: 6324748
  • Diff size: 82

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 24, 2024 •
edited
Loading

Chat bundle size is increased❗.

  • Current size: 2101743
  • Base size: 2101661
  • Diff size: 82

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 24, 2024 •
edited
Loading

Calling bundle size is not changed.

  • Current size: 4970781
  • Base size: 4970781
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 24, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ygqqqgpida.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 24, 2024 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26554 / 42481
62.5%		 26554 / 42481
62.5%		 720 / 1302
55.29%		 2088 / 3341
62.49%
Current 26521 / 42486
62.42%		 26521 / 42486
62.42%		 720 / 1302
55.29%		 2094 / 3337
62.75%
Diff -33 / 5
-0.08%		 -33 / 5
-0.08%		 0 / 0
0%		 6 / -4
0.26%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 25, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-jfjahonfpo.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 25, 2024

Failed to pass the component examples UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 25, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ntfaqwuqqt.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 25, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-gnzsyhcttt.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 25, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-qudoyybllt.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 25, 2024

Failed to pass the component examples UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 25, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-jubqyhbdnp.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 25, 2024

Failed to pass the component examples UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 25, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-tnnzdooqrf.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 25, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-jlkpgmdaxx.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 25, 2024

Failed to pass the component examples UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 25, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-vjcrdiipnm.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 25, 2024

Failed to pass the component examples UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 26, 2024

Failed to pass the component examples UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 26, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-umbthqbxzl.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 26, 2024

Failed to pass the component examples UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 26, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ygsngwjncl.chromatic.com/

@vhuseinova-msft vhuseinova-msft enabled auto-merge (squash) July 26, 2024 18:03
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 26, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-nktcfbenjy.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 26, 2024

Failed to pass the component examples UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 26, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-uzpwufhgvq.chromatic.com/

@vhuseinova-msft vhuseinova-msft merged commit 251870c into main Jul 26, 2024
@vhuseinova-msft vhuseinova-msft deleted the vhuseinova/rte-toolbar-bug-fix branch July 26, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@palatter palatter palatter approved these changes

@Leah-Xia-Microsoft Leah-Xia-Microsoft Leah-Xia-Microsoft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@palatter palatter

@Leah-Xia-Microsoft Leah-Xia-Microsoft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vhuseinova-msft @palatter @Leah-Xia-Microsoft
⚡