[A11y][bugfix] Add Role to SvgWithWordWrapping #5127
Merged
edwardlee-msft merged 4 commits intomainfrom Sep 6, 2024
Merged
Conversation
edwardlee-msft
requested review from
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
|
Storybook 6 URL https://60c7ae6891f0e90039d7cd54-fpgfqkowcz.chromatic.com/ |
Contributor
Chat bundle size is not changed.
|
Contributor
Calling bundle size is not changed.
|
Contributor
CallWithChat bundle size is not changed.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-leczmtctrf.chromatic.com/ |
alkwa-msft
approved these changes
Sep 6, 2024
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
JamesBurnside
approved these changes
Sep 6, 2024
Contributor
|
Storybook 6 URL https://60c7ae6891f0e90039d7cd54-dtuulzpdxl.chromatic.com/ |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-engybasfji.chromatic.com/ |
Contributor
|
Storybook 6 URL https://60c7ae6891f0e90039d7cd54-ewbdbuvcvy.chromatic.com/ |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-uulwvjvpqy.chromatic.com/ |
edwardlee-msft
deleted the
elee/bugfix-a11y-svg-text-announcing-graphic
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Video of the Fix in action. Turn up audio to hear. Go to the Why section to see the original problem in video.
Working.corectly.mov
Why
Graphic announced. Turn up audio to hear it in the video:
Graphic.announced.mov
How Tested
Window 11 Devbox
Process & policy checklist
Is this a breaking change?