Skip to content

Full screen captions banner api #5164

Merged
PorterNan merged 14 commits intomainfrom
jinan/hide-video-gallery
Sep 12, 2024
Merged

Full screen captions banner api #5164
PorterNan merged 14 commits intomainfrom
jinan/hide-video-gallery

Conversation

@PorterNan
Copy link
Copy Markdown
Contributor

@PorterNan PorterNan commented Sep 11, 2024

What

Full screen captions banner api (MTC project requirement), this will be only enabled when people set captionsBanner: {height: full}

image image

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@PorterNan PorterNan requested review from a team as code owners September 11, 2024 22:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 11, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-vytkelmods.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 11, 2024

Chat bundle size is not changed.

  • Current size: 1756343
  • Base size: 1756343
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 11, 2024

Calling bundle size is not changed.

  • Current size: 8139365
  • Base size: 8139365
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 11, 2024

CallWithChat bundle size is not changed.

  • Current size: 8139379
  • Base size: 8139379
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 11, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-wsngvvhlft.chromatic.com/

edwardlee-msft
edwardlee-msft reviewed Sep 11, 2024
View reviewed changes
Comment thread packages/react-components/src/components/CaptionsBanner.tsx Outdated
@PorterNan @edwardlee-msft
Update packages/react-components/src/components/CaptionsBanner.tsx
f6cf370 
Co-authored-by: edwardlee-msft <edwardlee@microsoft.com>
Signed-off-by: Porter Nan <jiangnanhello@live.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 11, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-hcthlftife.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 11, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-dhkmyneykz.chromatic.com/

dmceachernmsft
dmceachernmsft approved these changes Sep 11, 2024
View reviewed changes
Comment thread packages/react-components/src/components/CaptionsBanner.tsx Outdated
};
}

const SCROLL_OFF_SET_ALLOWANCE = 20;
Copy link
Copy Markdown
Member

@dmceachernmsft dmceachernmsft Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this offset for?

Copy link
Copy Markdown
Contributor Author

@PorterNan PorterNan Sep 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, why I can still pass the build, LOL, lemme fix this

@PorterNan
Update CaptionsBanner.tsx
993fd2e 
Signed-off-by: Porter Nan <jiangnanhello@live.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 11, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-qzobqewbaq.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 11, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-yrrzbohdge.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 12, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-hqfitajrmf.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 12, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-kwxfsxpzve.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 12, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-rkxxutdrtv.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 12, 2024

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26665 / 42814
62.28%		 26665 / 42814
62.28%		 727 / 1324
54.9%		 2097 / 3366
62.29%
Current 26660 / 42851
62.21%		 26660 / 42851
62.21%		 727 / 1324
54.9%		 2107 / 3374
62.44%
Diff -5 / 37
-0.07%		 -5 / 37
-0.07%		 0 / 0
0%		 10 / 8
0.15%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 12, 2024

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 53966 / 88288
61.12%		 53966 / 88288
61.12%		 1079 / 2467
43.73%		 3177 / 5232
60.72%
Current 53982 / 88387
61.07%		 53982 / 88387
61.07%		 1080 / 2468
43.76%		 3168 / 5245
60.4%
Diff 16 / 99
-0.05%		 16 / 99
-0.05%		 1 / 1
0.03%		 -9 / 13
-0.32%

@PorterNan PorterNan merged commit 870d010 into main Sep 12, 2024
@PorterNan PorterNan deleted the jinan/hide-video-gallery branch September 12, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmceachernmsft dmceachernmsft dmceachernmsft approved these changes

@edwardlee-msft edwardlee-msft edwardlee-msft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@dmceachernmsft dmceachernmsft

@edwardlee-msft edwardlee-msft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PorterNan @dmceachernmsft @edwardlee-msft
⚡