Skip to content

Fix video dispose problem for multiple video stream#5188

Merged
PorterNan merged 11 commits intomainfrom
jinan/fix-multiple
Oct 24, 2024
Merged

Fix video dispose problem for multiple video stream#5188
PorterNan merged 11 commits intomainfrom
jinan/fix-multiple

Conversation

@PorterNan
Copy link
Copy Markdown
Contributor

@PorterNan PorterNan commented Sep 18, 2024

What

Fix video dispose problem for multiple video stream

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@PorterNan PorterNan requested review from a team as code owners September 18, 2024 23:49
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 18, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-hscgddpdnb.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 18, 2024 •
edited
Loading

Chat bundle size is not changed.

  • Current size: 1757580
  • Base size: 1757580
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 18, 2024 •
edited
Loading

Calling bundle size is not changed.

  • Current size: 8139366
  • Base size: 8139366
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 18, 2024

CallWithChat bundle size is not changed.

  • Current size: 8139379
  • Base size: 8139379
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 18, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-vtbqyzletk.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 18, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 18, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 19, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-oqgeglhktv.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 26, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-pthwcaygvo.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 26, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-azsgyfxzmg.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 17, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 17, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-hntsfueptb.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 17, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 17, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-rmyfyehaoq.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 21, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 21, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 21, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-nhlundildc.chromatic.com/

@PorterNan PorterNan added the update_snapshots Set this label to request automated update of UI snapshots label Oct 24, 2024
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Oct 24, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 24, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-uearqkstxt.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 24, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 24, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-nayhdddysb.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 24, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-akkryxzyid.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 24, 2024 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26830 / 43197
62.11%		 26830 / 43197
62.11%		 733 / 1341
54.66%		 2105 / 3403
61.85%
Current 26902 / 43213
62.25%		 26902 / 43213
62.25%		 733 / 1341
54.66%		 2134 / 3424
62.32%
Diff 72 / 16
0.14%		 72 / 16
0.14%		 0 / 0
0%		 29 / 21
0.47%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 24, 2024 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 53840 / 88018
61.16%		 53840 / 88018
61.16%		 1093 / 2487
43.94%		 3208 / 5322
60.27%
Current 53811 / 88034
61.12%		 53811 / 88034
61.12%		 1093 / 2487
43.94%		 3214 / 5324
60.36%
Diff -29 / 16
-0.04%		 -29 / 16
-0.04%		 0 / 0
0%		 6 / 2
0.09%

@PorterNan PorterNan enabled auto-merge (squash) October 24, 2024 09:29
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 24, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-exbqaaifqq.chromatic.com/

@PorterNan PorterNan merged commit c6ef712 into main Oct 24, 2024
@PorterNan PorterNan deleted the jinan/fix-multiple branch October 24, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesBurnside JamesBurnside JamesBurnside approved these changes

@mgamis-msft mgamis-msft mgamis-msft approved these changes

@dmceachernmsft dmceachernmsft dmceachernmsft approved these changes

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@mgamis-msft mgamis-msft

@dmceachernmsft dmceachernmsft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PorterNan @JamesBurnside @mgamis-msft @dmceachernmsft
⚡