[JS-loaders] Stabilize feature#5198
Merged
dmceachernmsft merged 23 commits intomainfrom Oct 11, 2024
Merged
Conversation
dmceachernmsft
requested review from
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
JamesBurnside
approved these changes
Sep 23, 2024
PorterNan
approved these changes
Sep 23, 2024
Contributor
|
Storybook 6 URL https://60c7ae6891f0e90039d7cd54-nnjukikwix.chromatic.com/ |
Contributor
Calling bundle size is not changed.
|
Contributor
Chat bundle size is not changed.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-yjbuotumuj.chromatic.com/ |
Contributor
|
Storybook 6 URL https://60c7ae6891f0e90039d7cd54-hvrnilwszu.chromatic.com/ |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-azmnjpvqys.chromatic.com/ |
Contributor
|
Storybook 6 URL https://60c7ae6891f0e90039d7cd54-jlfodffezs.chromatic.com/ |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-vyxfwrdbyu.chromatic.com/ |
Contributor
|
Storybook 6 URL https://60c7ae6891f0e90039d7cd54-gpmnzitmgz.chromatic.com/ |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-devmqmzxzu.chromatic.com/ |
JamesBurnside
requested changes
Oct 8, 2024
JamesBurnside
approved these changes
Oct 8, 2024
Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com>
Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Stabilze JS-loader functions
Why
GA's the feature for GroupMe
How Tested
Built and tested locally CI to validate