[bugfix] Update notification spacing between title and description#5238
Merged
edwardlee-msft merged 12 commits intomainfrom Oct 3, 2024
Merged
[bugfix] Update notification spacing between title and description#5238edwardlee-msft merged 12 commits intomainfrom
edwardlee-msft merged 12 commits intomainfrom
Conversation
edwardlee-msft
requested review from
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
edwardlee-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
Chat bundle size is not changed.
|
Contributor
Calling bundle size is not changed.
|
Contributor
CallWithChat bundle size is not changed.
|
…m/Azure/communication-ui-library into elee/bugfix-notifications-spacing
…m/Azure/communication-ui-library into elee/bugfix-notifications-spacing
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-famjfsztyn.chromatic.com/ |
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
JamesBurnside
approved these changes
Oct 3, 2024
edwardlee-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
…m/Azure/communication-ui-library into elee/bugfix-notifications-spacing
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-wvlfaovqfu.chromatic.com/ |
dmceachernmsft
approved these changes
Oct 3, 2024
mgamis-msft
approved these changes
Oct 3, 2024
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-aljpggnjjw.chromatic.com/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Spacing did not match figma designs
How Tested
Process & policy checklist
Is this a breaking change?