Skip to content

Turn on no-getstate eslint rule and apply fixes#5239

Merged
JamesBurnside merged 16 commits intomainfrom
jaburnsi/apply-no-getstate-eslint-rules
Oct 4, 2024
Merged

Turn on no-getstate eslint rule and apply fixes#5239
JamesBurnside merged 16 commits intomainfrom
jaburnsi/apply-no-getstate-eslint-rules

Conversation

@JamesBurnside
Copy link
Copy Markdown
Member

@JamesBurnside JamesBurnside commented Oct 3, 2024 •
edited
Loading

What

Turn on no-getstate lint rule and apply fixes

Why

We need to be using useSelector anywhere where the state can change dynamically. This isn't strictly necessary in some cases but its too hard to know when adapter.getState can and can't be used so we are lighting up a lint rule to enforce it always

How Tested

Quick some test

image

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-gimuubrslh.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2024

CallWithChat bundle size is not changed.

  • Current size: 11750193
  • Base size: 11750193
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2024 •
edited
Loading

Chat bundle size is decreased✅.

  • Current size: 1756460
  • Base size: 1756581
  • Diff size: -121

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2024 •
edited
Loading

Calling bundle size is not changed.

  • Current size: 11750180
  • Base size: 11750180
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-axjgldgenm.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2024 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 53928 / 88220
61.12%		 53928 / 88220
61.12%		 1085 / 2475
43.83%		 3198 / 5275
60.62%
Current 54038 / 88319
61.18%		 54038 / 88319
61.18%		 1096 / 2485
44.1%		 3199 / 5271
60.69%
Diff 110 / 99
0.06%		 110 / 99
0.06%		 11 / 10
0.27%		 1 / -4
0.07%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2024 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26686 / 42905
62.19%		 26686 / 42905
62.19%		 729 / 1329
54.85%		 2118 / 3385
62.57%
Current 26680 / 42905
62.18%		 26680 / 42905
62.18%		 729 / 1329
54.85%		 2126 / 3393
62.65%
Diff -6 / 0
-0.01%		 -6 / 0
-0.01%		 0 / 0
0%		 8 / 8
0.08%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-sshdnayzjn.chromatic.com/

@JamesBurnside JamesBurnside marked this pull request as ready for review October 3, 2024 21:33
@JamesBurnside JamesBurnside requested review from a team as code owners October 3, 2024 21:33
@JamesBurnside JamesBurnside requested review from alkwa-msft, carocao-msft and dmceachernmsft and removed request for a team October 3, 2024 21:33
vhuseinova-msft
vhuseinova-msft reviewed Oct 4, 2024
View reviewed changes
Comment thread packages/react-composites/src/composites/ChatComposite/ChatScreen.tsx Outdated
vhuseinova-msft
vhuseinova-msft reviewed Oct 4, 2024
View reviewed changes
Comment thread packages/react-composites/src/composites/ChatComposite/ChatScreen.tsx
vhuseinova-msft
vhuseinova-msft reviewed Oct 4, 2024
View reviewed changes
Comment thread packages/react-composites/src/composites/ChatComposite/ChatScreen.tsx
vhuseinova-msft
vhuseinova-msft reviewed Oct 4, 2024
View reviewed changes
Comment thread packages/react-composites/src/composites/CallComposite/components/CallControls.tsx Outdated
@JamesBurnside JamesBurnside mentioned this pull request Oct 4, 2024
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 4, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-qtjbyjmnhg.chromatic.com/

vhuseinova-msft
vhuseinova-msft reviewed Oct 4, 2024
View reviewed changes
Comment thread packages/react-composites/src/composites/ChatComposite/ChatScreen.tsx Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 4, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-glhetscoko.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 4, 2024

Failed to pass the Static HTML UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@JamesBurnside @vhuseinova-msft
Update packages/react-composites/src/composites/ChatComposite/ChatScr…
b4fe4c4 
…een.tsx

Co-authored-by: vhuseinova-msft <98852890+vhuseinova-msft@users.noreply.github.com>
Signed-off-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 4, 2024

Failed to pass the Static HTML UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 4, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-eosfasiaix.chromatic.com/

@mgamis-msft
Copy link
Copy Markdown
Contributor

mgamis-msft commented Oct 4, 2024

Huge thanks for doing update!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 4, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ezkdbqxilx.chromatic.com/

Base automatically changed from jaburnsi/lint-rule to main October 4, 2024 21:13
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 4, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ruywexjlon.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 4, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-nrmjkiwxtm.chromatic.com/

@JamesBurnside JamesBurnside merged commit e4250e4 into main Oct 4, 2024
@JamesBurnside JamesBurnside deleted the jaburnsi/apply-no-getstate-eslint-rules branch October 4, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgamis-msft mgamis-msft mgamis-msft approved these changes

@edwardlee-msft edwardlee-msft edwardlee-msft approved these changes

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

+1 more reviewer

@vhuseinova-msft vhuseinova-msft vhuseinova-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mgamis-msft mgamis-msft

@edwardlee-msft edwardlee-msft

@vhuseinova-msft vhuseinova-msft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JamesBurnside @mgamis-msft @edwardlee-msft @vhuseinova-msft @Leah-Xia-Microsoft
⚡