Fix runtime error when starting screenshare alone in a call#5240
Merged
mgamis-msft merged 5 commits intomainfrom Oct 3, 2024
Merged
Fix runtime error when starting screenshare alone in a call#5240mgamis-msft merged 5 commits intomainfrom
mgamis-msft merged 5 commits intomainfrom
Conversation
mgamis-msft
requested review from
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
dmceachernmsft
approved these changes
Oct 3, 2024
Contributor
CallWithChat bundle size is not changed.
|
Contributor
Calling bundle size is not changed.
|
Contributor
Chat bundle size is not changed.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-rrhellbbje.chromatic.com/ |
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
JamesBurnside
approved these changes
Oct 3, 2024
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-gbqlerazjd.chromatic.com/ |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-lktopefinw.chromatic.com/ |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-bieowozgue.chromatic.com/ |
mgamis-msft
added a commit
that referenced
this pull request
Oct 3, 2024
* Fix runtime error when starting screenshare alone in a call * Change files * add unit test --------- Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com>
3 tasks
mgamis-msft
added a commit
that referenced
this pull request
Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix runtime error when starting screenshare alone in a call
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3904972
How Tested
Local calling sample test:
https://github.com/user-attachments/assets/5475e86a-1a98-4ae2-9694-e0cf58b10f9e
Screenshot of test:
Process & policy checklist
Is this a breaking change?