Skip to content

Fix noUncheckedIndexedAccess for react-composites#5297

Merged
JamesBurnside merged 7 commits intomainfrom
jaburnsi/noUncheckedIndexedAccess-reactComposites
Oct 15, 2024
Merged

Fix noUncheckedIndexedAccess for react-composites#5297
JamesBurnside merged 7 commits intomainfrom
jaburnsi/noUncheckedIndexedAccess-reactComposites

Conversation

@JamesBurnside
Copy link
Copy Markdown
Member

@JamesBurnside JamesBurnside commented Oct 10, 2024

What

Fix noUncheckedIndexedAccess for react-composites

Why

Housekeeping, continuation of #5242

How Tested

CI only

@JamesBurnside JamesBurnside requested a review from a team as a code owner October 10, 2024 19:53
@JamesBurnside JamesBurnside requested review from a team as code owners October 10, 2024 19:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 10, 2024 •
edited
Loading

Chat bundle size is increased❗.

  • Current size: 1757299
  • Base size: 1756794
  • Diff size: 505

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 10, 2024

Calling bundle size is not changed.

  • Current size: 11750180
  • Base size: 11750180
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 10, 2024

CallWithChat bundle size is not changed.

  • Current size: 11750193
  • Base size: 11750193
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 10, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-kdyobyanxg.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 10, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ymujfqnxme.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 10, 2024

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 10, 2024

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 10, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 10, 2024 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 54090 / 88327
61.23%		 54090 / 88327
61.23%		 1096 / 2484
44.12%		 3198 / 5291
60.44%
Current 54007 / 88358
61.12%		 54007 / 88358
61.12%		 1095 / 2483
44.09%		 3184 / 5294
60.14%
Diff -83 / 31
-0.11%		 -83 / 31
-0.11%		 -1 / -1
-0.03%		 -14 / 3
-0.3%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 10, 2024 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26770 / 43118
62.08%		 26770 / 43118
62.08%		 729 / 1335
54.6%		 2107 / 3407
61.84%
Current 26800 / 43118
62.15%		 26800 / 43118
62.15%		 729 / 1335
54.6%		 2112 / 3402
62.08%
Diff 30 / 0
0.07%		 30 / 0
0.07%		 0 / 0
0%		 5 / -5
0.24%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 10, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 10, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-aevibqnrmg.chromatic.com/

@JamesBurnside JamesBurnside enabled auto-merge (squash) October 15, 2024 01:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 15, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-vhkgianbjg.chromatic.com/

@JamesBurnside JamesBurnside merged commit e322858 into main Oct 15, 2024
@JamesBurnside JamesBurnside deleted the jaburnsi/noUncheckedIndexedAccess-reactComposites branch October 15, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emlynmac emlynmac emlynmac approved these changes

@edwardlee-msft edwardlee-msft edwardlee-msft approved these changes

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@emlynmac emlynmac

@PorterNan PorterNan

@edwardlee-msft edwardlee-msft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JamesBurnside @emlynmac @edwardlee-msft @PorterNan
⚡