Make environmentInfo stable - fixes safari speaker issue in stable#5328
Merged
JamesBurnside merged 8 commits intomainfrom Oct 17, 2024
Merged
Make environmentInfo stable - fixes safari speaker issue in stable#5328JamesBurnside merged 8 commits intomainfrom
JamesBurnside merged 8 commits intomainfrom
Conversation
JamesBurnside
requested review from
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
JamesBurnside
commented
Oct 17, 2024
| await deviceManager.getSpeakers(); | ||
| } | ||
| /* @conditional-compile-remove(unsupported-browser) */ | ||
| await callClient.feature(Features.DebugInfo).getEnvironmentInfo(); |
Member
Author
There was a problem hiding this comment.
this is now moved to happening in the statefulcallclient constructor
Contributor
CallWithChat bundle size is not changed.
|
Contributor
Calling bundle size is not changed.
|
Contributor
Chat bundle size is not changed.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-zuafuromqm.chromatic.com/ |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-gcdqtiqmit.chromatic.com/ |
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
edwardlee-msft
approved these changes
Oct 17, 2024
PorterNan
approved these changes
Oct 17, 2024
dmceachernmsft
approved these changes
Oct 17, 2024
JamesBurnside
added a commit
that referenced
this pull request
Oct 17, 2024
JamesBurnside
added a commit
that referenced
this pull request
Oct 17, 2024
* Make environmentInfo stable - fixes safari speaker issue in stable (#5328) * update changelog * update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
We use this internally for multiple calculations and should not be locked behind unsupported-browser, e.g. we use it for hiding the speaker selection dropdown on safari
How Tested
Ran locally and verified environment info is coming through:
