Fix CallComposite captions to correctly be <li> items#5375
Merged
JamesBurnside merged 6 commits intomainfrom Nov 5, 2024
Merged
Fix CallComposite captions to correctly be <li> items#5375JamesBurnside merged 6 commits intomainfrom
<li> items#5375JamesBurnside merged 6 commits intomainfrom
Conversation
Contributor
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-dnfluelxwi.chromatic.com/ |
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-khpakduikg.chromatic.com/ |
dmceachernmsft
approved these changes
Oct 31, 2024
edwardlee-msft
approved these changes
Nov 5, 2024
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-umnasacyvq.chromatic.com/ |
Contributor
Chat bundle size is not changed.
|
Contributor
Calling bundle size is not changed.
|
Contributor
CallWithChat bundle size is not changed.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-nugmlicrje.chromatic.com/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ulto be the parent of the captionsliWhy
A11y bug.
More details:
How Tested
verified locally:
verified spoken language RTL working: