Skip to content

Fix CallComposite captions to correctly be <li> items#5375

Merged
JamesBurnside merged 6 commits intomainfrom
jaburnsi/fix-captions-ul-li
Nov 5, 2024
Merged

Fix CallComposite captions to correctly be <li> items#5375
JamesBurnside merged 6 commits intomainfrom
jaburnsi/fix-captions-ul-li

Conversation

@JamesBurnside
Copy link
Copy Markdown
Member

@JamesBurnside JamesBurnside commented Oct 30, 2024

What

  • Update location of ul to be the parent of the captions
  • Update the captions parent-most element to be an li

Why

A11y bug.

More details:

Actual result:
The Live Captions region within the call UI contains an incorrectly structured list. The list has direct child elements that are not valid. Instead of containing only <li> (list item) elements, it currently contains <div> elements

Expected result: 
Ensures that lists are structured correctly (list - https://accessibilityinsights.io/info-examples/web/list)

The Live Captions region should contain only <li> elements as direct children of the <ul> element

Element path: 
.css-113

Snippet: 
<ul class="ms-FocusZone css-490 css-113" data-ui-id="captions-banner" data-tabster="{&quot;uncontrolled&quot;: {}}" data-focuszone-id="FocusZone4727">

How Tested

verified locally:

image

verified spoken language RTL working:

image

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 30, 2024

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 54198 / 89406
60.62%
54198 / 89406
60.62%
1102 / 2522
43.69%
3203 / 5336
60.02%
Current 54220 / 89416
60.63%
54220 / 89416
60.63%
1102 / 2522
43.69%
3213 / 5337
60.2%
Diff 22 / 10
0.01%
22 / 10
0.01%
0 / 0
0%
10 / 1
0.18%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 30, 2024

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26873 / 43376
61.95%
26873 / 43376
61.95%
734 / 1350
54.37%
2160 / 3445
62.69%
Current 26877 / 43387
61.94%
26877 / 43387
61.94%
734 / 1350
54.37%
2152 / 3438
62.59%
Diff 4 / 11
-0.01%
4 / 11
-0.01%
0 / 0
0%
-8 / -7
-0.1%

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 5, 2024

@JamesBurnside JamesBurnside enabled auto-merge (squash) November 5, 2024 22:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 5, 2024

Chat bundle size is not changed.

  • Current size: 1758915
  • Base size: 1758915
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 5, 2024

Calling bundle size is not changed.

  • Current size: 8139366
  • Base size: 8139366
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 5, 2024

CallWithChat bundle size is not changed.

  • Current size: 8139379
  • Base size: 8139379
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 5, 2024

@JamesBurnside JamesBurnside merged commit b2107eb into main Nov 5, 2024
@JamesBurnside JamesBurnside deleted the jaburnsi/fix-captions-ul-li branch November 5, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants