Skip to content

[A11y bugfix] Configuration screen dropdown allow button keyboard navigation#5384

Merged
dmceachernmsft merged 7 commits intomainfrom
dmceachernsmft/dropdown-box-config
Nov 2, 2024
Merged

[A11y bugfix] Configuration screen dropdown allow button keyboard navigation#5384
dmceachernmsft merged 7 commits intomainfrom
dmceachernsmft/dropdown-box-config

Conversation

@dmceachernmsft
Copy link
Copy Markdown
Member

@dmceachernmsft dmceachernmsft commented Nov 1, 2024 •
edited
Loading

What

Allows for users to action the allow button directly with the keyboard inside the dropdown when permisssions aren't set

Why

Allows for better keyboard navigation on the Configuration screen

https://skype.visualstudio.com/SPOOL/_workitems/edit/3911504

How Tested

Validated Locally
image

@dmceachernmsft dmceachernmsft requested review from a team as code owners November 1, 2024 00:09
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 1, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-bijvujxtej.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 1, 2024 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26871 / 43336
62%		 26871 / 43336
62%		 733 / 1346
54.45%		 2145 / 3433
62.48%
Current 26871 / 43351
61.98%		 26871 / 43351
61.98%		 733 / 1346
54.45%		 2145 / 3433
62.48%
Diff 0 / 15
-0.02%		 0 / 15
-0.02%		 0 / 0
0%		 0 / 0
0%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 1, 2024 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 53936 / 88562
60.9%		 53936 / 88562
60.9%		 1100 / 2492
44.14%		 3244 / 5359
60.53%
Current 53863 / 88578
60.8%		 53863 / 88578
60.8%		 1100 / 2492
44.14%		 3205 / 5331
60.12%
Diff -73 / 16
-0.1%		 -73 / 16
-0.1%		 0 / 0
0%		 -39 / -28
-0.41%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 1, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@dmceachernmsft dmceachernmsft added the update_snapshots Set this label to request automated update of UI snapshots label Nov 1, 2024
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Nov 1, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 1, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-epfdoszmom.chromatic.com/

JamesBurnside
JamesBurnside reviewed Nov 1, 2024
View reviewed changes
Comment thread .../CallReadiness.test.ts-snapshots/call-readiness-permission-disabled-Desktop-Chrome-linux.png
Copy link
Copy Markdown
Member

@JamesBurnside JamesBurnside Nov 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the mic button in the preview change size?
image

Perhaps it wasn't a big enough change to be captured before when we changed the sizing a while back?

JamesBurnside
JamesBurnside reviewed Nov 1, 2024
View reviewed changes
Comment thread ...adiness.test.ts-snapshots/call-readiness-camera-permission-disabled-Desktop-Chrome-linux.png
Copy link
Copy Markdown
Member

@JamesBurnside JamesBurnside Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intenional the Allow text is now bold?

Copy link
Copy Markdown
Member

@JamesBurnside JamesBurnside Nov 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also looks less vertically centered than before:
image
(shifted up 1-2 pixels)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 1, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-dzhhvjrfwm.chromatic.com/

@dmceachernmsft dmceachernmsft added the update_snapshots Set this label to request automated update of UI snapshots label Nov 1, 2024
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Nov 1, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 1, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-xpkckbgpjb.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 1, 2024

CallWithChat bundle size is not changed.

  • Current size: 8139379
  • Base size: 8139379
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 1, 2024

Calling bundle size is not changed.

  • Current size: 8139366
  • Base size: 8139366
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 1, 2024

Chat bundle size is not changed.

  • Current size: 1758914
  • Base size: 1758914
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 1, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-nddvpiywsn.chromatic.com/

@dmceachernmsft dmceachernmsft merged commit ae93b41 into main Nov 2, 2024
@dmceachernmsft dmceachernmsft deleted the dmceachernsmft/dropdown-box-config branch November 2, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesBurnside JamesBurnside JamesBurnside approved these changes

@edwardlee-msft edwardlee-msft edwardlee-msft approved these changes

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@JamesBurnside JamesBurnside

@edwardlee-msft edwardlee-msft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dmceachernmsft @JamesBurnside @edwardlee-msft
⚡