[bugfix][a11y] Add announcement strings for page status#5400
Merged
edwardlee-msft merged 4 commits intomainfrom Nov 8, 2024
Merged
[bugfix][a11y] Add announcement strings for page status#5400edwardlee-msft merged 4 commits intomainfrom
edwardlee-msft merged 4 commits intomainfrom
Conversation
edwardlee-msft
requested review from
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ydrvcheorn.chromatic.com/ |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-fycufamnjd.chromatic.com/ |
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
JamesBurnside
approved these changes
Nov 7, 2024
| className={mergeStyles(titleStyle(palette, isVideoReady))} | ||
| aria-live="assertive" | ||
| data-ui-id="lobbyScreenTitle" | ||
| role="alert" |
Member
There was a problem hiding this comment.
We should probably add this to the notification component also... 👀
Member
There was a problem hiding this comment.
May need it in the config message bars too... 👀
(beta)
(stable)
Contributor
Author
There was a problem hiding this comment.
I don't know about adding alerts into the notifications and error bar for now... i think we punt it and see what remains for now
Contributor
CallWithChat bundle size is not changed.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
Calling bundle size is not changed.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ineirbynzd.chromatic.com/ |
dmceachernmsft
approved these changes
Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Announcement string updates for page statuses.
Why
A11y bug
How Tested
Process & policy checklist
Is this a breaking change?