[Bugfix] update Audio context creation#5476
Merged
dmceachernmsft merged 9 commits intomainfrom Dec 9, 2024
Merged
Conversation
dmceachernmsft
requested review from
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
alkwa-msft,
carocao-msft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-cdxhdtvijc.chromatic.com/ |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-gneqfthybn.chromatic.com/ |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-uliobbgnde.chromatic.com/ |
…zure/communication-ui-library into dmceachernmsft/audioContextFix
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-iqbkybkzrf.chromatic.com/ |
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-lgqkotpwft.chromatic.com/ |
carocao-msft
approved these changes
Dec 9, 2024
mgamis-msft
approved these changes
Dec 9, 2024
Contributor
Chat bundle size is increased❗.
|
Contributor
Calling bundle size is not changed.
|
Contributor
CallWithChat bundle size is not changed.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-haobcxpzvh.chromatic.com/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix issue where Audio Context for composite is made too soon causing a warning
Why
stops the audio context from being created before the basecomposite is rendered
https://skype.visualstudio.com/SPOOL/_workitems/edit/3964464
How Tested
Built and tested locally to check if warnings show in the console