Alkwa/update calling versions#5508
Merged
alkwa-msft merged 12 commits intomainfrom Dec 18, 2024
Merged
Conversation
alkwa-msft
requested review from
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-hogntbcjjb.chromatic.com/ |
…g the correct stable calling sdk version
edwardlee-msft
approved these changes
Dec 17, 2024
dmceachernmsft
approved these changes
Dec 17, 2024
| public isTranscriptionActive = false; | ||
| public emitter = new EventEmitter(); | ||
| public isConsentRequired = false; | ||
| public isTeamsConsentRequired = false; |
Member
There was a problem hiding this comment.
is this in stable as well? we have a CC comment for this calling-sdk-beta if not
Contributor
Author
There was a problem hiding this comment.
that's a good point I will CC those lines as well! Thanks for bringing this up
jimchou-dev
approved these changes
Dec 17, 2024
…g-versions' into alkwa/update-calling-versions
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ujnbppgmry.chromatic.com/ |
…g-versions' into alkwa/update-calling-versions
Contributor
CallWithChat bundle size is not changed.
|
Contributor
Chat bundle size is decreased✅.
|
Contributor
Calling bundle size is not changed.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-tgxcetkmmp.chromatic.com/ |
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.