Skip to content

[Bugfix] Remove unreachable code#5520

Merged
jimchou-dev merged 3 commits intomainfrom
jimchou/remove-unreachable-code
Jan 7, 2025
Merged

[Bugfix] Remove unreachable code#5520
jimchou-dev merged 3 commits intomainfrom
jimchou/remove-unreachable-code

Conversation

@jimchou-dev
Copy link
Copy Markdown
Member

What

Remove unreachable code after return statement

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 20, 2024

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27852 / 44258
62.93%
27852 / 44258
62.93%
780 / 1418
55%
2306 / 3672
62.79%
Current 27855 / 44245
62.95%
27855 / 44245
62.95%
780 / 1418
55%
2306 / 3667
62.88%
Diff 3 / -13
0.02%
3 / -13
0.02%
0 / 0
0%
0 / -5
0.09%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 20, 2024

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 56216 / 92248
60.94%
56216 / 92248
60.94%
1153 / 2655
43.42%
3475 / 5708
60.87%
Current 56166 / 92227
60.89%
56166 / 92227
60.89%
1153 / 2655
43.42%
3453 / 5684
60.74%
Diff -50 / -21
-0.05%
-50 / -21
-0.05%
0 / 0
0%
-22 / -24
-0.13%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 7, 2025

Calling bundle size is not changed.

  • Current size: 11767065
  • Base size: 11767065
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 7, 2025

CallWithChat bundle size is not changed.

  • Current size: 11767078
  • Base size: 11767078
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 7, 2025

Chat bundle size is not changed.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 7, 2025

@jimchou-dev jimchou-dev merged commit 0bb81df into main Jan 7, 2025
@jimchou-dev jimchou-dev deleted the jimchou/remove-unreachable-code branch January 7, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants