[Ezra bug] change behavior to tab to close and remove focus zone.#5524
Merged
dmceachernmsft merged 10 commits intomainfrom Dec 26, 2024
Merged
[Ezra bug] change behavior to tab to close and remove focus zone.#5524dmceachernmsft merged 10 commits intomainfrom
dmceachernmsft merged 10 commits intomainfrom
Conversation
dmceachernmsft
requested review from
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
alkwa-msft,
carocao-msft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-cdlftrwkug.chromatic.com/ |
alkwa-msft
reviewed
Dec 24, 2024
| const controlBarRef = useRef<FocusableElement>(null); | ||
| const peopleButtonRef = useRef<IButton>(null); | ||
| const cameraButtonRef = useRef<IButton>(null); | ||
| const sidePaneDissmissButtonRef = useRef<IButton>(null); |
Contributor
There was a problem hiding this comment.
What's diss?! ;) Dissmiss or Dismiss?
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
carocao-msft
approved these changes
Dec 24, 2024
Contributor
carocao-msft
left a comment
carocao-msft
left a comment
There was a problem hiding this comment.
Looks good aside from the typo 'diss'
alkwa-msft
approved these changes
Dec 24, 2024
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-maxtbndupm.chromatic.com/ |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-lzwemtuvwe.chromatic.com/ |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-fdxbqlqcxm.chromatic.com/ |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-hzasigsvhj.chromatic.com/ |
Contributor
CallWithChat bundle size is not changed.
|
Contributor
Calling bundle size is not changed.
|
Contributor
Chat bundle size is decreased✅.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-iujlpxsmki.chromatic.com/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates people pane tabbing behavior
Why
Makes it so that there is no trapping behavior from the people pane in the CallComposite and CallWithChatComposite.
https://skype.visualstudio.com/SPOOL/_workitems/edit/3832347
How Tested
Validated locally