Fix acs room audio video enabled notifications#5563
Merged
Conversation
fuyan2024
requested review from
JamesBurnside,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
fuyan2024
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
fuyan2024
changed the title
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
dmceachernmsft
approved these changes
Jan 16, 2025
fuyan2024
requested review from
JoshuaLai,
Leah-Xia-Microsoft,
emlynmac,
jpeng-ms,
palatter,
vhuseinova-msft and
waynemo
Contributor
Calling bundle size is not changed.
|
Contributor
CallWithChat bundle size is not changed.
|
Contributor
Chat bundle size is not changed.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-gaodfwzxzk.chromatic.com/ |
carocao-msft
approved these changes
Jan 16, 2025
fuyan2024
added a commit
that referenced
this pull request
Jan 16, 2025
3 tasks
fuyan2024
added a commit
that referenced
this pull request
Jan 16, 2025
carocao-msft
added a commit
that referenced
this pull request
Jan 24, 2025
* stable-remove-beta-suffix version bump * Collect CHANGELOG * Create groom me file for groom changelog branch (#5549) * Create groom me file for groom changelog branch * groomc * update * Update CHANGELOG to consolidate PR referencesupdate --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * change (#5557) * Bump package versions to beta.0 for next release * Cherry pick PR: #5563 * revert previous commit * Update * update --------- Signed-off-by: carocao-msft <96077406+carocao-msft@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: fuyan <fuyan@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
How Tested
Acs user join a room as presenter:
Before:
After:
Process & policy checklist
Is this a breaking change?