Skip to content

Hide read by in chat action flyout when participants is 20 or more#5585

Merged
palatter merged 4 commits intomainfrom
palatter/hide-read
Jan 30, 2025
Merged

Hide read by in chat action flyout when participants is 20 or more#5585
palatter merged 4 commits intomainfrom
palatter/hide-read

Conversation

@palatter
Copy link
Copy Markdown
Member

Read count is returned as 0 when their are 20 or more participants. So we should hide the read by option on the flyout in this case.

What

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

Chat bundle size is increased❗.

  • Current size: 1776793
  • Base size: 1776763
  • Diff size: 30

@github-actions
Copy link
Copy Markdown
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27935 / 44344
62.99%
27935 / 44344
62.99%
783 / 1424
54.98%
2347 / 3718
63.12%
Current 27878 / 44345
62.86%
27878 / 44345
62.86%
783 / 1424
54.98%
2332 / 3705
62.94%
Diff -57 / 1
-0.13%
-57 / 1
-0.13%
0 / 0
0%
-15 / -13
-0.18%

@github-actions
Copy link
Copy Markdown
Contributor

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 57189 / 94354
60.61%
57189 / 94354
60.61%
1161 / 2687
43.2%
3476 / 5736
60.59%
Current 57191 / 94356
60.61%
57191 / 94356
60.61%
1161 / 2687
43.2%
3477 / 5738
60.59%
Diff 2 / 2
0%
2 / 2
0%
0 / 0
0%
1 / 2
0%

@palatter palatter merged commit 72b4f8b into main Jan 30, 2025
@palatter palatter deleted the palatter/hide-read branch January 30, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants