Skip to content

Assign default value to captions mobile drawers #5626

Merged
carocao-msft merged 7 commits intomainfrom
carocao/captionsBug
Feb 7, 2025
Merged

Assign default value to captions mobile drawers #5626
carocao-msft merged 7 commits intomainfrom
carocao/captionsBug

Conversation

@carocao-msft
Copy link
Copy Markdown
Contributor

What

Assign default value to captions mobile drawers

Why

https://skype.visualstudio.com/SPOOL/_workitems/edit/3989285

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 6, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27984 / 44639
62.68%
27984 / 44639
62.68%
786 / 1435
54.77%
2346 / 3715
63.14%
Current 27984 / 44645
62.68%
27984 / 44645
62.68%
786 / 1435
54.77%
2341 / 3713
63.04%
Diff 0 / 6
0%
0 / 6
0%
0 / 0
0%
-5 / -2
-0.1%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 6, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 56995 / 94128
60.55%
56995 / 94128
60.55%
1161 / 2689
43.17%
3445 / 5713
60.3%
Current 57008 / 94138
60.55%
57008 / 94138
60.55%
1161 / 2689
43.17%
3457 / 5718
60.45%
Diff 13 / 10
0%
13 / 10
0%
0 / 0
0%
12 / 5
0.15%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 6, 2025

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 6, 2025

@carocao-msft carocao-msft enabled auto-merge (squash) February 7, 2025 00:35
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 7, 2025

Chat bundle size is not changed.

  • Current size: 1777206
  • Base size: 1777206
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 7, 2025

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 7, 2025

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 7, 2025

@carocao-msft carocao-msft merged commit c118cfd into main Feb 7, 2025
@carocao-msft carocao-msft deleted the carocao/captionsBug branch February 7, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants