Style update for RTT#5627
Merged
carocao-msft merged 10 commits intomainfrom Feb 6, 2025
Merged
Conversation
carocao-msft
added
the
update_snapshots
carocao-msft
requested review from
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
alkwa-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
github-actions
Bot
removed
the
update_snapshots
Contributor
CallWithChat bundle size is not changed.
|
Contributor
Chat bundle size is decreased✅.
|
Contributor
Calling bundle size is not changed.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-nyygrjkzye.chromatic.com/ |
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
dmceachernmsft
approved these changes
Feb 6, 2025
mgamis-msft
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Horizontal margins of RTT thread and input box seem too large
RTT input box styling: border appears darker than spec, corner radius too small.
Shadow beneath RTT banner (RTT is enabled for all participants...) getting clipped on left and right side
Why
How Tested
Process & policy checklist
Is this a breaking change?