[A11y bugfix] config heading aria level#5638
Merged
dmceachernmsft merged 3 commits intomainfrom Feb 12, 2025
Merged
Conversation
dmceachernmsft
requested review from
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
alkwa-msft,
carocao-msft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-daxdcqlqsz.chromatic.com/ |
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
JamesBurnside
approved these changes
Feb 11, 2025
| return ( | ||
| <svg role={role} width={width} height={height + bufferHeightPx} ref={svgRef} xmlns="http://www.w3.org/2000/svg"> | ||
| <svg | ||
| aria-level={1} |
Member
There was a problem hiding this comment.
in the event of the compsite being used alongside other UI on a webpage this could be incorrect.
But also it's our brst guess so if a customer needs it different then perhaps we expose an api at that stage.
lgtm!
edwardlee-msft
approved these changes
Feb 12, 2025
Contributor
CallWithChat bundle size is not changed.
|
Contributor
Calling bundle size is not changed.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-tdppddvhsw.chromatic.com/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update the aria level for the heading SVG on the config screen
Why
Makes sure our elements are the correct level for screen readers
https://skype.visualstudio.com/SPOOL/_workitems/edit/4031933
How Tested
Validated locally with A11y insights
Process & policy checklist