Add delay to switching source#5650
Merged
JamesBurnside merged 4 commits intomainfrom Feb 16, 2025
Merged
Conversation
JamesBurnside
requested review from
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
edwardlee-msft
approved these changes
Feb 14, 2025
dmceachernmsft
approved these changes
Feb 14, 2025
Contributor
CallWithChat bundle size is not changed.
|
Contributor
Calling bundle size is not changed.
|
Contributor
Chat bundle size is not changed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add 1second delay to indicating switch source completed to throttle switching source
Why
Fix bug where switching camera on iphone may cause stream to freeze for remote participants. We have also filed a bug on the communication-calling package to fix this internally and not need this arbitrary delay.
How Tested
Locally on iphone 11 and android pixel