Fix screenshare button text to be black in dark mode #5654
Merged
JamesBurnside merged 3 commits intomainfrom Feb 18, 2025
Merged
Fix screenshare button text to be black in dark mode #5654JamesBurnside merged 3 commits intomainfrom
JamesBurnside merged 3 commits intomainfrom
Conversation
…dark mode primary button
JamesBurnside
added
the
update_snapshots
JamesBurnside
requested review from
JoshuaLai,
Leah-Xia-Microsoft,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
github-actions
Bot
removed
the
update_snapshots
JamesBurnside
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
Calling bundle size is not changed.
|
Contributor
CallWithChat bundle size is not changed.
|
Contributor
Chat bundle size is not changed.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-mxphjfxlrn.chromatic.com/ |
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
edwardlee-msft
approved these changes
Feb 18, 2025
mgamis-msft
reviewed
Feb 18, 2025
| color: DefaultPalette.white, | ||
| background: theme.semanticColors.primaryButtonBackground, | ||
| color: theme.semanticColors.primaryButtonText, | ||
| ':focus::after': { outlineColor: `${DefaultPalette.white} !important` }, // added !important to avoid override by FluentUI button styles |
Contributor
There was a problem hiding this comment.
Should we also update the :focus::after outline color here and on hover below?
Member
Author
There was a problem hiding this comment.
They're actually intentional - the black outline is really hard to see, I'd only want to update if we get A11y complaining about it
mgamis-msft
reviewed
Feb 18, 2025
| background: theme.palette.themePrimary, | ||
| color: DefaultPalette.white, | ||
| background: theme.semanticColors.primaryButtonBackground, | ||
| color: theme.semanticColors.primaryButtonText, |
Contributor
There was a problem hiding this comment.
Cool. Good use of semantic colors.
mgamis-msft
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update screenshare button stylings to match a regular primary button
Why
Screenshare button icon was black but text was white. Both should be black.
How Tested
No impact to high contrast modes: