Skip to content

[onFetchProfile] Add onFetchProfile for CallWithChat composite #5729

Merged
prabhjot-msft merged 13 commits intomainfrom
prabhjot/onFetchProfile-Rabobank
Apr 9, 2025
Merged

[onFetchProfile] Add onFetchProfile for CallWithChat composite #5729
prabhjot-msft merged 13 commits intomainfrom
prabhjot/onFetchProfile-Rabobank

Conversation

@prabhjot-msft
Copy link
Copy Markdown
Contributor

What

Add UI library support for onFetchProfile in CallWithChat composite

  1. Add participant state modifier and display name modifier in chat composite
  2. Add on Fetch profile callback in Chat adapter
OnFetchProfile-Demo.mov

Why

https://skype.visualstudio.com/SPOOL/_workitems/edit/4066751
https://skype.visualstudio.com/SPOOL/_workitems/edit/4066752

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

Comment thread packages/communication-react/review/beta/communication-react.api.md Outdated
@github-actions
Copy link
Copy Markdown
Contributor

Comment thread samples/CallWithChat/src/app/views/CallScreen.tsx Outdated
Comment thread common/config/babel/features.js
@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2025

Calling bundle size is not changed.

  • Current size: 12401036
  • Base size: 12401036
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2025

CallWithChat bundle size is not changed.

  • Current size: 12401048
  • Base size: 12401048
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2025

Chat bundle size is increased❗.

  • Current size: 1780242
  • Base size: 1776584
  • Diff size: 3658

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2025

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 28107 / 44748
62.81%
28107 / 44748
62.81%
788 / 1439
54.76%
2346 / 3725
62.97%
Current 28160 / 44748
62.93%
28160 / 44748
62.93%
788 / 1439
54.76%
2350 / 3728
63.03%
Diff 53 / 0
0.12%
53 / 0
0.12%
0 / 0
0%
4 / 3
0.06%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58383 / 94346
61.88%
58383 / 94346
61.88%
1180 / 2698
43.73%
3535 / 5844
60.48%
Current 58523 / 94714
61.78%
58523 / 94714
61.78%
1181 / 2701
43.72%
3558 / 5859
60.72%
Diff 140 / 368
-0.1%
140 / 368
-0.1%
1 / 3
-0.01%
23 / 15
0.24%

@prabhjot-msft prabhjot-msft marked this pull request as ready for review April 8, 2025 21:45
@prabhjot-msft prabhjot-msft requested review from a team as code owners April 8, 2025 21:45
@prabhjot-msft prabhjot-msft merged commit 62d7971 into main Apr 9, 2025
40 of 41 checks passed
@prabhjot-msft prabhjot-msft deleted the prabhjot/onFetchProfile-Rabobank branch April 9, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants