[Notifications] hide notification#5751
Merged
dmceachernmsft merged 13 commits intomainfrom Apr 3, 2025
Merged
Conversation
dmceachernmsft
requested review from
JamesBurnside,
Leah-Xia-Microsoft,
alkwa-msft,
carocao-msft,
edwardlee-msft,
jimchou-dev,
jpeng-ms,
mgamis-msft,
prabhjot-msft and
vhuseinova-msft
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-fvrsltaevr.chromatic.com/ |
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-qwttoniybf.chromatic.com/ |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-zwqyssovzl.chromatic.com/ |
Member
Author
|
Bundle size changed caused by new strings in component package for new notifications |
carocao-msft
previously approved these changes
Apr 2, 2025
…m/Azure/communication-ui-library into dmceachernmsft/hide-notifications
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ysuqmdtvsx.chromatic.com/ |
Member
JamesBurnside
left a comment
JamesBurnside
left a comment
There was a problem hiding this comment.
LGTM! Just some naming suggestions on the latest iteration
…pi.md Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com>
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-gsmkontmth.chromatic.com/ |
Contributor
Chat bundle size is increased❗.
|
Contributor
CallWithChat bundle size is not changed.
|
Contributor
Calling bundle size is not changed.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-zkwztgjzlg.chromatic.com/ |
carocao-msft
approved these changes
Apr 2, 2025
| togetherModeEnded: 'NotificationBarTogetherModeIcon' | ||
| togetherModeEnded: 'NotificationBarTogetherModeIcon', | ||
| transcriptionError: 'NotificationBarTranscriptionError', | ||
| transcriptionStartedByYou: 'NotificationBartranscriptionStartedByYou' |
Member
There was a problem hiding this comment.
Suggested change
| transcriptionStartedByYou: 'NotificationBartranscriptionStartedByYou' | |
| transcriptionStartedByYou: 'NotificationBarTranscriptionStartedByYou' |
JamesBurnside
approved these changes
Apr 3, 2025
Member
JamesBurnside
left a comment
JamesBurnside
left a comment
There was a problem hiding this comment.
Try fix the notificationoptions_2 weirdness before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add API to hide the notifications in the CallComposite.
Why
We want to allow Contoso to use their own notification stack to be able to show custom notifcations in a composite experience
How Tested
Built and tested locally
