Skip to content

Maintain muted state when joining and leaving breakout rooms#5765

Merged
mgamis-msft merged 2 commits intomainfrom
mgamis/maintain-muted-state-when-joining-and-leaving-breakout-rooms
Apr 7, 2025
Merged

Maintain muted state when joining and leaving breakout rooms#5765
mgamis-msft merged 2 commits intomainfrom
mgamis/maintain-muted-state-when-joining-and-leaving-breakout-rooms

Conversation

@mgamis-msft
Copy link
Copy Markdown
Contributor

What

Maintain muted state when joining and leaving breakout rooms

Why

Resolves one of the issues from #5755 regarding not maintaining the muted state when joining and leaving breakout rooms.

How Tested

Tested locally.

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2025

CallWithChat bundle size is not changed.

  • Current size: 12401048
  • Base size: 12401048
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2025

Calling bundle size is not changed.

  • Current size: 12401036
  • Base size: 12401036
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2025

Chat bundle size is decreased✅.

  • Current size: 1776584
  • Base size: 1776585
  • Diff size: -1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2025

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 28164 / 44748
62.93%
28164 / 44748
62.93%
788 / 1439
54.76%
2351 / 3727
63.08%
Current 28109 / 44748
62.81%
28109 / 44748
62.81%
788 / 1439
54.76%
2334 / 3712
62.87%
Diff -55 / 0
-0.12%
-55 / 0
-0.12%
0 / 0
0%
-17 / -15
-0.21%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58433 / 94338
61.94%
58433 / 94338
61.94%
1180 / 2698
43.73%
3585 / 5877
61%
Current 58403 / 94346
61.9%
58403 / 94346
61.9%
1180 / 2698
43.73%
3536 / 5849
60.45%
Diff -30 / 8
-0.04%
-30 / 8
-0.04%
0 / 0
0%
-49 / -28
-0.55%

@mgamis-msft mgamis-msft enabled auto-merge (squash) April 7, 2025 18:10
@mgamis-msft mgamis-msft merged commit f4c1503 into main Apr 7, 2025
41 checks passed
@mgamis-msft mgamis-msft deleted the mgamis/maintain-muted-state-when-joining-and-leaving-breakout-rooms branch April 7, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants