Move width/height calculation on call page for Video Gallery#5777
Merged
carocao-msft merged 14 commits intomainfrom Apr 11, 2025
Merged
Move width/height calculation on call page for Video Gallery#5777carocao-msft merged 14 commits intomainfrom
carocao-msft merged 14 commits intomainfrom
Conversation
carocao-msft
added
the
update_snapshots
carocao-msft
requested review from
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
alkwa-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
github-actions
Bot
removed
the
update_snapshots
Contributor
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-gsfjlejhzx.chromatic.com/ |
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
carocao-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-jhdkorvrzi.chromatic.com/ |
Member
dmceachernmsft
left a comment
dmceachernmsft
left a comment
There was a problem hiding this comment.
Can we maybe change this so that we are only affecting the localVideoTile size API and not how the vertical gallery is decided? we want to make sure its behavior is still on the gallery for optimal positioning in screenshare and other views.
carocao-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
…nication-ui-library into carocao/videoGallery
…nication-ui-library into carocao/videoGallery
…nication-ui-library into carocao/videoGallery
Contributor
Calling bundle size is not changed.
|
Contributor
CallWithChat bundle size is not changed.
|
Contributor
Chat bundle size is not changed.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ouwzvlksia.chromatic.com/ |
JamesBurnside
approved these changes
Apr 11, 2025
dmceachernmsft
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bug fix for video gallery showing horizontal view when RTT banner is enlarged
Why
How Tested
Process & policy checklist
Is this a breaking change?