Skip to content

Fix bug where the scrollable div is not keyboard accessible#5806

Merged
carocao-msft merged 9 commits intomainfrom
carocao/rtt
Apr 30, 2025
Merged

Fix bug where the scrollable div is not keyboard accessible#5806
carocao-msft merged 9 commits intomainfrom
carocao/rtt

Conversation

@carocao-msft
Copy link
Copy Markdown
Contributor

What

https://skype.visualstudio.com/SPOOL/_workitems/edit/4111341

How Tested

Screenshot 2025-04-29 at 4 53 16 PM

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 28326 / 45691
61.99%
28326 / 45691
61.99%
794 / 1451
54.72%
2351 / 3738
62.89%
Current 28321 / 45691
61.98%
28321 / 45691
61.98%
794 / 1451
54.72%
2372 / 3751
63.23%
Diff -5 / 0
-0.01%
-5 / 0
-0.01%
0 / 0
0%
21 / 13
0.34%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58511 / 94884
61.66%
58511 / 94884
61.66%
1184 / 2710
43.69%
3395 / 5767
58.86%
Current 58525 / 94885
61.67%
58525 / 94885
61.67%
1184 / 2710
43.69%
3392 / 5762
58.86%
Diff 14 / 1
0.01%
14 / 1
0.01%
0 / 0
0%
-3 / -5
0%

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@carocao-msft carocao-msft added the update_snapshots Set this label to request automated update of UI snapshots label Apr 30, 2025
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Apr 30, 2025
@github-actions
Copy link
Copy Markdown
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12413574
  • Base size: 12413574
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

Calling bundle size is not changed.

  • Current size: 12413561
  • Base size: 12413561
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

Chat bundle size is not changed.

  • Current size: 1781063
  • Base size: 1781063
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

@carocao-msft carocao-msft enabled auto-merge (squash) April 30, 2025 17:16
@carocao-msft carocao-msft merged commit 49c50ea into main Apr 30, 2025
41 checks passed
@carocao-msft carocao-msft deleted the carocao/rtt branch April 30, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants