PSTN/1:N Enable ringing tone during connecting and ringing state #5808
PSTN/1:N Enable ringing tone during connecting and ringing state #5808edwardlee-msft merged 6 commits intomainfrom
Conversation
edwardlee-msft
requested review from
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
alkwa-msft,
carocao-msft,
dmceachernmsft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-uitsbmuerj.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-gfzmhtdcjv.chromatic.com/ |
…s play in ringing and connecting states
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-lhniylexfo.chromatic.com/ |
CallWithChat bundle size is not changed.
|
Calling bundle size is not changed.
|
Chat bundle size is not changed.
|
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-kafioqrhtr.chromatic.com/ |
@azure/communication-react jest test coverage for beta.
|
@azure/communication-react jest test coverage for stable.
|
| !isPhoneNumberIdentifier(callees[0]) && | ||
| (call.state === 'Ringing' || call.state === 'Connecting') | ||
| ) { | ||
| if (callees && callees[0] && (call.state === 'Ringing' || call.state === 'Connecting')) { |
There was a problem hiding this comment.
FYI: Removed the phonenumberidentifier check entirely as the fix is to only apply ringing in connecting and ringing states. We will not produce ringing in "EarlyMedia" state in case there is a clash with remote ringing tones coming from carriers.
Spoken with Sola Akanmu (PSTN poc), they noted there is no pstn check preventing remote ringing from occuring in EarlyMedia state. Hence why the local ringing tone will only be present during "Ringing" and "Connecting" states. (Contoso provides ringing audio file)
There was a problem hiding this comment.
In the future, If there is feedback from Contoso requesting that there be an option to add a ringing tone during early media as well, we can provide an options bag for them to do so.
| }); | ||
|
|
||
| test('should not play sound when call is made to PSTN user', () => { | ||
| test('should play sound when call is made to PSTN user and stop when EarlyMedia', () => { |
There was a problem hiding this comment.
Tests were updated to reflect the new changes.
PSTN calls will now have ringing incorporated but will not have it incorporated in "EarlyMedia" state.
Contoso can easily override this behavior by providing no audio track for ringing.
3 participants
What
Enable ringing tone during connecting and ringing state
Why
No audible indication that a call is ringing or connecting to a pstn/1:N participant
How Tested
MacOS, Calling Sample.
Called Teams number, Telus number, Freedom number.
Process & policy checklist
Is this a breaking change?