[JS loaders package] add base composite props#5811
Merged
dmceachernmsft merged 6 commits intomainfrom May 12, 2025
Merged
Conversation
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-dliwhobkjj.chromatic.com/ |
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-chfjuhjwao.chromatic.com/ |
…ub.com/Azure/communication-ui-library into dmceachernmsft/loaders-composite-props
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-xczhmyzwym.chromatic.com/ |
dmceachernmsft
requested review from
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
alkwa-msft,
carocao-msft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
prabhjot-msft
approved these changes
May 12, 2025
edwardlee-msft
approved these changes
May 12, 2025
Contributor
Chat bundle size is increased❗.
|
Contributor
Calling bundle size is not changed.
|
Contributor
CallWithChat bundle size is not changed.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-qzscmrpufz.chromatic.com/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add props for base composite to loaders
Proposing the above because it would look like the following if we flatten it for each composite
Issue: in the signature of the function if they want to use theme but not locale locale would need to be set as
undefinedSolution: Props bag is cleaner in this situation for each composite.
Why
#5809
How Tested
Testing with local angular app and bundle