Add selector changes for unnamed participants that left call#5812
Merged
prabhjot-msft merged 5 commits intomainfrom May 1, 2025
Merged
Add selector changes for unnamed participants that left call#5812prabhjot-msft merged 5 commits intomainfrom
prabhjot-msft merged 5 commits intomainfrom
Conversation
…-client-participants-ended
prabhjot-msft
requested review from
JamesBurnside,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft and
mgamis-msft
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
| * @internal | ||
| * | ||
| */ | ||
| export const getRemoteParticipantDisplayName = ( |
Member
There was a problem hiding this comment.
Other properties beyond display name in future may want all remote participants ended.
A different way to structure this PR, would be to create a new selector getAllRemoteParticipants that returns active and previous participants. Then where getRemoteParticipants, getRemoteParticipantsEnded is used as arguments into the reselect, you can just use getAllRemoteParticipants knowing it will retrieve both active and previous participants.
Just a recommendation, I won't block on this, otherwise PR looks great! Nice find on this property
Contributor
Author
There was a problem hiding this comment.
Will be implementing this in separate PR.
JamesBurnside
approved these changes
May 1, 2025
dmceachernmsft
approved these changes
May 1, 2025
Contributor
CallWithChat bundle size is not changed.
|
Contributor
Chat bundle size is not changed.
|
Contributor
Calling bundle size is not changed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add selector changes for unnamed participants that left call
Before:
Screen.Recording.2025-04-30.at.3.00.28.PM.mov
After:
Screen.Recording.2025-04-30.at.2.57.39.PM.mov
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/4115057
How Tested
Process & policy checklist
Is this a breaking change?