Fix issue on Android WebView where there is no default audio device#5900
Merged
JamesBurnside merged 3 commits intomainfrom Jun 17, 2025
Merged
Fix issue on Android WebView where there is no default audio device#5900JamesBurnside merged 3 commits intomainfrom
JamesBurnside merged 3 commits intomainfrom
Conversation
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-lirejfwmgv.chromatic.com/ |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-vjthjnmzrg.chromatic.com/ |
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
JamesBurnside
requested review from
JoshuaLai,
Leah-Xia-Microsoft,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
JamesBurnside
commented
Jun 17, 2025
| } | ||
| ); | ||
|
|
||
| function removeBlankNameDevices<T extends { name: string }>(devices: T[]): T[] { |
Member
Author
There was a problem hiding this comment.
We have verified removing this does not cause any regression on macas safari with usePropsFor and devices button
dmceachernmsft
approved these changes
Jun 17, 2025
| [getDeviceManager], | ||
| (deviceManager) => { | ||
| return { | ||
| microphones: removeBlankNameDevices(deviceManager.microphones), |
Contributor
There was a problem hiding this comment.
are the blank name devices coming only from webview, do we need to filter any other devices that might cause issue?
Member
Author
There was a problem hiding this comment.
Validated the scenario with donald that removeBlankNameDevices was applied for and it no longer repros, but if we see regressions we can look at other solution. It was originally added here #2366 as a workaround where the SDK was putting in a fake camera when there wasn't camera permission - but its not reproing any longer (this was back in 2022)
prabhjot-msft
approved these changes
Jun 17, 2025
JamesBurnside
added
does not need changelog
Contributor
📦 Calling bundle size
Total change: +1.1 KB |
Contributor
📦 CallWithChat bundle size
Total change: +1.1 KB |
Contributor
📦 Chat bundle size
Total change: +86 B |
JamesBurnside
added a commit
that referenced
this pull request
Jun 18, 2025
…5900) * Fix issue on Android WebView where there is no default audio device * Change files * updatge api files
JamesBurnside
added a commit
that referenced
this pull request
Jun 18, 2025
…5900) * Fix issue on Android WebView where there is no default audio device * Change files * updatge api files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
For config page and for call page, ensure we use a default fallback for the device name for microphone if the default microphone does not have one.
Why
Fix issue on Android WebView where there is no default audio device. The default audio device on android webview has no label:
How Tested
Verified on android web view and verified usePropsFor on devicesbutton on macos safari